PS: Remove request holding #3604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holding requests in the PS can lead to a lot of outstanding requests if a certain destination AS is not running. The holding of requests helped to make integration tests more stable, because at the start of a full topology it is true that segments will be registered in the future, in general this does not hold. For production code this can lead to a lot of CPU usage for nothing.
1d0df13 to
7b3c477
Compare
karampok
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
karampok
approved these changes
Jan 14, 2020
There was a problem hiding this comment.
Reviewable status:
matzf
added a commit
to matzf/scion
that referenced
this pull request
May 6, 2020
These have become unused by removing the request holding feature in scionproto#3604.
matzf
added a commit
to matzf/scion
that referenced
this pull request
May 12, 2020
These have become unused by removing the request holding feature in scionproto#3604.
lukedirtwalker
pushed a commit
that referenced
this pull request
May 12, 2020
* Remove code for segment request validation This segment request validation appears to never have been activated. This will be solved differently in the future, by having a separate segment request handler for local requests (TCP only) and, in core ASes only, a simpler handler for requests from other path servers (over SCION/QUIC). This will simplify the validation of the requests, so the existing code would not help a lot. * Remove unused `RetrySleep` and `IsParamsLocal` from segreq. These have become unused by removing the request holding feature in #3604. Replace use of now unneeded `segreq.LocalInfo` interface with `segfetcher.LocalInfo`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Holding requests in the PS can lead to a lot of outstanding requests
if a certain destination AS is not running.
The holding of requests helped to make integration tests more stable,
because at the start of a full topology it is true that segments will be registered in the future,
in general this does not hold.
For production code this can lead to a lot of CPU usage for nothing.
This change is