Lint: Update flake8 #3559
Lint: Update flake8 #3559
Conversation
ff4f473 to
daa0d9d
Compare
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @JordiSubira, @scrye, @sgmonroy, and @worxli)
python/lib/packet/host_addr.py, line 200 at r1 (raw file):
def haddr_get_type(type_): # pragma: no cover r"""
why this change?
python/lib/packet/host_addr.py, line 214 at r1 (raw file):
def haddr_parse(type_, *args, **kwargs): # pragma: no cover r"""
ditto
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)
python/lib/packet/host_addr.py, line 200 at r1 (raw file):
Previously, Oncilla wrote…
why this change?
I used raw string to make the W605 of pylint disappear with the backslash char.
python/lib/packet/host_addr.py, line 214 at r1 (raw file):
Previously, Oncilla wrote…
ditto
Idem
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewable status:
solving out conflicts new version flake8, removing flake8 entries env/debian/pkgs.txt
daa0d9d to
281245a
Compare
There was a problem hiding this comment.
Reviewed 1 of 2 files at r3.
Reviewable status:
Updates flake8 to 3.7.9 to have type annotation support. Install flake8 via pip instead of debian, remove from debian deps. Also fix issues flagged by the new version.
Updates flake8 to 3.7.9 to have type annotation support.
Install flake8 via pip instead of debian, remove from debian deps.
Also fix issues flagged by the new version.
This change is