Skip to content

Fix removing IPv6 registrations in godispatcher #3531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 18, 2019
Merged

Fix removing IPv6 registrations in godispatcher #3531

merged 2 commits into from
Dec 18, 2019

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Dec 16, 2019 •
edited
Loading

Analogous to #3451, but now for removing registrations.

This time, I double checked: there should be no further instances of this particular bug. :)

This change is Reviewable

@matzf matzf force-pushed the dispatcher-ipv6-free branch from 291dd68 to c88fbb8 Compare December 17, 2019 07:08
@matzf matzf force-pushed the dispatcher-ipv6-free branch from c88fbb8 to f4d7387 Compare December 18, 2019 08:57
scrye
scrye approved these changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit c11f446 into scionproto:master Dec 18, 2019
@matzf matzf deleted the dispatcher-ipv6-free branch December 18, 2019 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@scrye scrye scrye approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@scrye scrye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matzf @scrye