Fix IPv6 registrations in godispatcher #3451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e45a398 to
4a6d504
Compare
scrye
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
4a6d504 to
ee5d936
Compare
scrye
approved these changes
Dec 5, 2019
There was a problem hiding this comment.
Reviewable status:
The godispatcher uses two separate port tables for IPv4 and IPv6 addresses. While the lookup has selected the applicable table based on the address type, the registration was always using the table for IPv4. Also enhance the tests for UDPTable to check that a lookup actually succeeds after a registration.
ee5d936 to
f729501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The godispatcher uses two separate port tables for IPv4 and IPv6
addresses. While the lookup has selected the applicable table based on
the address type, the registration was always using the table for IPv4.
Also enhance the tests for UDPTable to check that a lookup actually
succeeds after a registration.
This change is