dispatcher socket file mode. #3124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Move the FileMode type to util. Refactor. Use FileMode also in the dispatcher. Relates to scionproto#3099.
ece7193 to
c19e79f
Compare
juagargi
added a commit
to netsec-ethz/scion
that referenced
this pull request
Sep 9, 2019
Makes the file mode of the socket file configurable. (default 0770) Abstracts the sciond FileMode type into util package and uses it in both configs. Relates to scionproto#3099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the file mode of the socket file configurable. (default 0770)
Abstracts the sciond FileMode type into util package and uses it in both configs.
Relates to #3099
This change is