Acceptance: Reduce query interval on sciond #3089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the next query does not consider path expiration time. (see # 2979) This PR reduces the query interval for sciond in the sig_short_exp_time expiration test.
4cd8d82 to
d63980d
Compare
scrye
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
oncilla
added a commit
to oncilla/scion
that referenced
this pull request
Oct 1, 2019
oncilla
added a commit
to oncilla/scion
that referenced
this pull request
Oct 2, 2019
oncilla
added a commit
that referenced
this pull request
Oct 2, 2019
With this PR, the next query is dependent on the verified segments. The next query interval is at least minQueryInterval and at most the configured query interval. However, if only segments are found where the time until segment expiration minus the `expirationLeadTime` (2 minutes) are found that are less than the configured query interval, then that is chosen. I.e. the query interval is: ```` maxExpirationDiff = max(seg.Exp().Add(-expirationLeadTime).Sub(now)) min(max(minQueryInterval, maxExpirationDiff), QueryInterval) ```` fixes #2979 Also, revert band-aid fix introduced by #3089
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the next query does not consider path expiration time. (see #2979)
This PR reduces the query interval for sciond in the
sig_short_exp_timeexpiration test.This change is