Switch to a more reliable way of creating go/vendor symlinks. #2982
Conversation
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kormat)
README.md, line 48 at r1 (raw file):
- (Optional: for go tools compatability with bazel) Install
This is also needed for generating mocks. Calling it optional will just create confusion IMO.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kormat)
WORKSPACE, line 194 at r1 (raw file):
) go_repository(
Maybe add a comment to go_rules mentioning that updating the version may result in upgrading these repositories.
There was a problem hiding this comment.
Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on @sustrik)
README.md, line 48 at r1 (raw file):
Previously, sustrik (Martin Sustrik) wrote…
This is also needed for generating mocks. Calling it optional will just create confusion IMO.
I would have counted that as a go tool issue, but sure, i can remove that parenthesis.
WORKSPACE, line 194 at r1 (raw file):
Previously, sustrik (Martin Sustrik) wrote…
Maybe add a comment to go_rules mentioning that updating the version may result in upgrading these repositories.
Once we go to a newer version of rules_go, then we have to explicitly import these dependencies, they no longer do it implicitly (that's one of the big changes in 0.9+).
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Also: - Remove no-op go_repository rules that are shadowed by the version of rules_go we're using: https://github.com/bazelbuild/rules_go/blob/0.18.7/go/private/repositories.bzl#L26
There was a problem hiding this comment.
Reviewed 1 of 4 files at r3.
Reviewable status: 4 of 6 files reviewed, all discussions resolved (waiting on @sustrik)
There was a problem hiding this comment.
Reviewable status: 4 of 6 files reviewed, all discussions resolved (waiting on @sustrik)
There was a problem hiding this comment.
Reviewed 1 of 4 files at r3.
Reviewable status: 5 of 6 files reviewed, all discussions resolved (waiting on @sustrik)
There was a problem hiding this comment.
Reviewed 1 of 4 files at r3.
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4.
Reviewable status:
This change allows generating prototype TRC payloads. A prototype TRC will be signed and then combined to a signed TRC. Signing and combining is left for a future PR. For convenience, a 'gen' command will also be added in the future that executes the three phases in a single call. contributes to scionproto#2982
This change allows generating prototype TRC payloads. A prototype TRC will be signed and then combined to a signed TRC. Signing and combining is left for a future PR. For convenience, a 'gen' command will also be added in the future that executes the three phases in a single call. contributes to scionproto#2982
Also:
rules_go we're using:
https://github.com/bazelbuild/rules_go/blob/0.18.7/go/private/repositories.bzl#L26
This change is