private/env: remove RunsInDocker during startup log #4499
Conversation
|
This change is |
There was a problem hiding this comment.
Indeeed, I'd propose to remove RunsInDocker entirely; I can't quite see the usefulness of this information.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JordiSubira)
private/env/logging.go line 45 at r1 (raw file):
return serrors.WrapStr("Unable to determine if running in docker", err) } }
If we do keep the RunsInDocker check, I'd propose to apply the same pattern as the implementation in statuspages.go; attempt to call RunsInDocker and entirely omit the line if the call errors.
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @matzf)
private/env/logging.go line 45 at r1 (raw file):
Previously, matzf (Matthias Frei) wrote…
If we do keep the
RunsInDockercheck, I'd propose to apply the same pattern as the implementation in statuspages.go; attempt to callRunsInDockerand entirely omit the line if the call errors.
Done, after removing it completely.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf and @oncilla)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @JordiSubira)
The use of the platform-dependent flag syscall.MSG_WAITFORONE prevents building the router on platforms other than Linux. This change isolates this dependency. Behavior on non-Linux platforms will be less efficient but still semantically correct because ReadBatch will only read a single message on those platforms anyway. Together with the previous PR #4499 and the dispatcher removal PR #4344 this set of changes will, e.g., enable running local development topologies on platforms other than Linux. Fixes #4046.
This PR tries to remove a Linux-only dependency for running SCION applications of other platforms. The
RunsUnDocker()method is the Linux-only call, thus we check whether we are running in Docker only in Linux platform. I am in favor of even removing this log line, supporting @matzf comment on https://reviewable.io/reviews/scionproto/scion/4344#-Nt_IGRG4RbvC-PCVToV.