cmd/scion: set payload size appropriately if --max-mtu is set #4250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The maxMTU flag for the scion ping overwrites the payload size which is used when initializing the ping config. There was an error that the updated payload size was not used during initialization.
Changes:
- changed the value used for the PayloadSize for the ping config
oncilla
reviewed
Sep 8, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @bunert)
oncilla
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @bunert)
benthor
pushed a commit
to benthor/scion
that referenced
this pull request
Nov 24, 2022
…roto#4250) Correct the behavior of the `--max-mtu` flag for `scion ping`. Previously, there was a bug where the calculated payload size was ignored and the value from `--payload-size` was taken. In most cases, this would be the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the behavior of the
--max-mtuflag forscion ping.Previously, there was a bug where the calculated payload size was ignored and the value from
--payload-sizewas taken.In most cases, this would be the default.
This change is