Skip to content

PS: segreq handler should log more about fetcher errors and reply with NACK/error #3091

@lukedirtwalker

Description

@lukedirtwalker

If the segfetcher logic in the PS returns an error, the handler silently returns, we should log the error and return a negative reply to the client.

Problematic code:

segs, err := h.fetcher.FetchSegs(ctx,
segfetcher.Request{Src: segReq.SrcIA(), Dst: segReq.DstIA()})
if err != nil {
return infra.MetricsErrInternal
}

and missing logging in:
if err = rw.SendSegReply(ctx, reply); err != nil {
return infra.MetricsErrInternal
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions