Skip to content

PS: Log & return err from segfetcher #3092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2019
Merged

PS: Log & return err from segfetcher #3092

merged 1 commit into from
Sep 4, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Sep 4, 2019 •
edited by kormat
Loading

Instead of silently bailing out.

Fixes #3091

This change is Reviewable

@lukedirtwalker lukedirtwalker self-assigned this Sep 4, 2019
oncilla
oncilla approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker
PS: Log & return err from segfetcher
964af72 
Instead of silently bailing out.

Fixes scionproto#3091
@lukedirtwalker lukedirtwalker merged commit df2dcd8 into scionproto:master Sep 4, 2019
@lukedirtwalker lukedirtwalker deleted the pubPSFix branch September 4, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oncilla oncilla oncilla approved these changes

Assignees

@lukedirtwalker lukedirtwalker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PS: segreq handler should log more about fetcher errors and reply with NACK/error
2 participants
@lukedirtwalker @oncilla