fix(fastapi): theme #6526
Closed
fix(fastapi): theme #6526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4404ef2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Wait, can you elaborate on the issue? We definitely want to keep a custom theme for FastAPI as the default. There must be another way to fix the issue. |
I've tried setting the @api.get("/scalar", include_in_schema=False)
async def scalar_html():
return get_scalar_api_reference(
openapi_url=api.openapi_url,
title=api.title,
theme=Theme.SOLARIZED, # not work
)When I empty the @api.get("/scalar", include_in_schema=False)
async def scalar_html():
return get_scalar_api_reference(
openapi_url=api.openapi_url,
title=api.title,
scalar_theme="",
theme=Theme.SOLARIZED, # work now
) |
|
Ah, got it! Yeah, there’s a lot of strange things going on. Fixing it… |
4 tasks
|
Closing in favor of #6552 ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After #6256, we don't have to use hardcoded theme styles anymore. Also, if we set the
themebut not thescalar_theme, the hardcoded style will take priority and make the theme ineffective.Solution
With this PR …
Checklist
I've gone through the following:
pnpm changeset).