-
Notifications
You must be signed in to change notification settings - Fork 442
feat(fastapi): new HTML/JS API #6552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d641110 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
#12365 Bundle Size — 2.65MiB (0%).d641110(current) vs 98bfa38 main#12363(baseline) Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
|
Current #12365 |
Baseline #12363 |
|
---|---|---|
2.65MiB |
2.65MiB |
|
0B |
0B |
|
0% |
0% |
|
1 |
1 |
|
1 |
1 |
|
1817 |
1817 |
|
0 |
0 |
|
0% |
0% |
|
168 |
168 |
|
1 |
1 |
Bundle analysis report Branch feat/new-html-js-api-for-fastapi Project dashboard
Generated by RelativeCI Documentation Report issue
Scalar Components Snapshot Test ResultsDetails
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested but the code looks good
The current release has a few painful regressions, I’ve tested it manually and it has tests and I think @marclave is too busy to review rn, so I'll just merge it and queue it up for release. |
Problem
In #6526 @zrquan reported a bug, where you can’t overwrite the default FastAPI theme. I wanted to fix that, but was shocked we're still using the old JS API.
Solution
This PR refactors the integration to use the new HTML/JS API. This also fixes the mentioned bug, where the theme can’t be overwritten.
Checklist
I've gone through the following:
pnpm changeset
).