ScannerTokens: change LFLF pointPos to first LF #3780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8256e1 to
69b12d2
Compare
Turns out it improves semanticDB symbol detection and makes it handle names followed by a single newline vs multiple newlines consistently.
bjaglin
added a commit
to bjaglin/scalafix
that referenced
this pull request
Aug 24, 2024
Breaking changes in internals - scalameta/scalameta#3747 - semanticdb stubs & symtab/metap helpers were spinned off from main artifact - scalameta/scalameta#3780 - synthetic empty constructors are now included in semanticdb - scalameta/scalameta#3826 - reflect rename of internal implicit class in scalameta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out it improves semanticDB symbol detection and makes it handle names followed by a single newline vs multiple newlines consistently.