Skip to content

bugfix: match completions for type aliases scala 3 #5714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 11, 2023
Merged

bugfix: match completions for type aliases scala 3 #5714

merged 2 commits into from
Oct 11, 2023

Conversation

kasiaMarek
Copy link
Member

resolves: #5712

@kasiaMarek kasiaMarek added Scala 3 Generic ticket relating to Scala 3 presentation-compiler Something relating to the presentation compiler labels Oct 5, 2023
@kasiaMarek kasiaMarek requested a review from jkciesluk October 5, 2023 08:12
filipwiech
filipwiech reviewed Oct 5, 2023
View reviewed changes
tests/cross/src/test/scala/tests/pc/CompletionMatchSuite.scala
@@ -734,4 +734,52 @@ class CompletionMatchSuite extends BaseCompletionSuite {
filter = _.contains("exhaustive"),
)

checkEdit(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These cases already seem to work for Scala 2 (with Animal being sealed type hierarchy instead of enum). Would it be worth it to add unit tests for it as well (or maybe there are already some)? 🙂

jkciesluk
jkciesluk requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For case completions I think you need to change it also here https://github.com/scalameta/metals/pull/5714/files#diff-8cca6f591058d93dae851ed5830ec69c9172cb020410921fe8dddff10d3d8e9eR153

kpodsiad
kpodsiad approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@kpodsiad kpodsiad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

filipwiech
filipwiech approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@filipwiech filipwiech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding Scala 2 tests. 👍

jkciesluk
jkciesluk approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kasiaMarek kasiaMarek mentioned this pull request Oct 9, 2023
Merged
tgodzik added a commit to scala/scala3 that referenced this pull request Oct 9, 2023
@tgodzik
fix: match completions for type aliases (#18667)
00180bb 
metals backport:  scalameta/metals#5714
CC: @tgodzik
@kasiaMarek kasiaMarek merged commit 92e9732 into scalameta:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpodsiad kpodsiad kpodsiad approved these changes

@jkciesluk jkciesluk jkciesluk approved these changes

+1 more reviewer

@filipwiech filipwiech filipwiech approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
presentation-compiler Something relating to the presentation compiler Scala 3 Generic ticket relating to Scala 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing match completions for type wrapped in Id
4 participants
@kasiaMarek @filipwiech @kpodsiad @jkciesluk