Delay hard argument comparisons #20007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When comparing arguments of two applied types, perform hard comparisons after easy ones. A comparison if hard if it entails a subtype test A <: B where A is an AndType or B is an OrType. Such comparisons need to perform an either, which might lose solutions. Fixes scala#19999
|
We could possibly generalize this, delaying hard comparisons in more conjunctive tests, not just type in arguments. But it is hard in general to identify a conjunctive subsequence of tests when doing a subtype traversal. |
|
Interesting! I've had a case that required this defer too. |
smarter
approved these changes
Mar 25, 2024
| * So we defer such tests to run last, on the chance that some other argument | ||
| * comparison will instantiate or constrain type variables first. | ||
| */ | ||
| def isHard(arg1: Type, arg2: Type): Boolean = |
There was a problem hiding this comment.
Using the word hard here might lead to confuse with hard unions since OrTypes are also involved. Maybe we could call this isIncomplete instead?
smarter
approved these changes
Mar 25, 2024
Co-authored-by: Guillaume Martres <smarter@ubuntu.com>
WojciechMazur
added a commit
that referenced
this pull request
Jul 5, 2024
Backports #20007 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing arguments of two applied types, perform hard comparisons after easy ones. A comparison is hard if it entails a subtype test A <: B where A is an AndType or B is an OrType. Such comparisons need to perform an either, which might lose solutions.
Fixes #19999