Error instead of StaleSymbol crash for certain cyclic macro dependencies #19549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a suspended macro refers back to a symbol in a previously compiled package object, report this as an error instead of crashing with a StaleSymbol exception. There's unfortunately not a lot of info available at the point where the error is raised, so the error message is a bit vague. But it's better than crashing.
nicolasstucki
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a suspended macro refers back to a symbol in a previously compiled package object, report this as an error instead of crashing with a StaleSymbol exception.
There's unfortunately not a lot of info available at the point where the error is raised, so the error message is a bit vague. But it's better than crashing.
Fixes #19351