Skip to content

Use comma counting for all signature help types #19520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2024
Merged

Use comma counting for all signature help types #19520

merged 1 commit into from
Jan 26, 2024

Conversation

rochala
Copy link
Contributor

@rochala rochala commented Jan 23, 2024

@rochala rochala requested a review from jkciesluk January 23, 2024 14:29
jkciesluk
jkciesluk approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@jkciesluk jkciesluk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rochala rochala merged commit 1716bcd into scala:main Jan 26, 2024
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
@tgodzik tgodzik added the area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools label May 8, 2024
WojciechMazur pushed a commit that referenced this pull request Jun 27, 2024
@rochala @WojciechMazur
Use comma counting for all signature help types (#19520)
bbba7b9 
Fixes scalameta/metals#6040
[Cherry-picked 1716bcd]
@WojciechMazur WojciechMazur mentioned this pull request Jun 27, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 28, 2024
@WojciechMazur
Backport "Use comma counting for all signature help types" to LTS (#2…
f38e5e0 
…0854)

Backports #19520 to the LTS branch.

PR submitted by the release tooling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jkciesluk jkciesluk jkciesluk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@jkciesluk jkciesluk

Labels
area:presentation-compiler Related to the presentation compiler module used by Metals and possibly other tools
Projects
None yet
Milestone
3.4.1
Development

Successfully merging this pull request may close these issues.

Incorrect activeParameter in type declarations for signature help.
4 participants
@rochala @jkciesluk @tgodzik @Kordyjan