double-typed buff_len #146
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstenner
approved these changes
Oct 4, 2021
|
@tstenner had a good idea to make this typedef enum {
transp_default = 0, // keep legacy behavior
transp_buffsize_samples = 1, // the supplied int is in samples
transp_buffsize_thousandths = 2, // Indicates whether the supplied int should be (double)/1000
transp_synch = 4, // the outlet will use synchronous (blocking) zero-copy pushes
transp_disable_endianness = 8, // disable endianness conversions
} lsl_transport_options_t; |
|
This is such a trivial detail, but do we have any consistency as to whether the common short-form for 'buffer' should be |
…bandwidth streams where 1 sec is too long.
bad96d6 to
08024cc
Compare
|
Rebased on #155. Let's wait on that one to be merged so we can easily see the (comparatively very small) changes. |
tstenner
requested changes
Oct 11, 2021
|
Rebased and merged in 0b35dba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new methods to the C API and an overloaded method to the C++ API to allow the user to set the buffer length with a double instead of an integer. This is necessary in very-high channel count and samplerate situations where even 1-second is too much. Obviously a sub-1-second buffer means that the system won't be able to recover from a disconnect without data loss but at these data rates that isn't really possible anyway (unless we want to start buffering to disk).