Skip to content

Replace Boost.Asio with plain Asio #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Replace Boost.Asio with plain Asio #155

merged 3 commits into from
Oct 28, 2021

Conversation

tstenner
Copy link
Collaborator

@tstenner tstenner commented Oct 6, 2021

Closes #143.

@tstenner tstenner requested a review from cboulay October 6, 2021 14:00
@cboulay
Copy link
Collaborator

cboulay commented Oct 6, 2021

It would also be good to get @chausner to look at this.

@chausner
Copy link
Contributor

chausner commented Oct 6, 2021

It would also be good to get @chausner to look at this.

Don't really have an opinion on this as I am not really familiar with those libraries. At least, I can't think of any reason that would speak against this change.

@tstenner
Copy link
Collaborator Author

tstenner commented Oct 8, 2021

@chausner The main parts that might be relevant to you (out of all the 352833 changed lines :-) are:

  • Asio is included as #include <asio/ instead of #include <boost/asio, so unless …/include/boost/ is on the include path, no part of Boost.Asio is imported any more
  • the Asio include path is added to the lslobj target, not lslboost
  • -D_WIN32_WINNT=…, mswsock and ws2_32 are no longer needed for lslboost and can be moved to lslobj

Building the PR with MSVC (shared/static) didn't produce any new warnings that those flags were missing, but maybe there's something I have forgotten.

@tstenner
Copy link
Collaborator Author

Rebased and built successfully against the Android NDK

@tstenner tstenner merged commit f048715 into sccn:master Oct 28, 2021
@tstenner tstenner deleted the asio branch October 28, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate replacing boost::asio with regular asio
3 participants