don't require publishTo specified if publishArtifact is false
#3760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good change. Could you add a test for this use case so we don't regress, please? Either to an existing scripted test or a new one. Given this isn't (as far as I understand) a regression in behaviour since sbt 0.13, I think it's safer merge this in 1.x, so it participates in a release candidate phase. |
|
FWIW If |
d63b2f1 to
991c71d
Compare
|
348b0d3 to
93b18b6
Compare
|
the travis errors look like flukes. @dwijnand anything else stopping this to get merged? |
dwijnand
approved these changes
Dec 1, 2017
|
green enough @dwijnand ? |
Even with `publishArtifact := false` the user is still forced to define a (dummy) resolver that's never used, e.g. `publishTo := { Some("publishMeNot" at "https://publish/me/not") }`
Otherwise the following error is thrown:
```
publish
[error] java.lang.RuntimeException: Repository for publishing is not specified.
[error] at scala.sys.package$.error(package.scala:27)
[error] at sbt.Classpaths$.$anonfun$getPublishTo$1(Defaults.scala:2436)
[error] at scala.Option.getOrElse(Option.scala:121)
[error] at sbt.Classpaths$.getPublishTo(Defaults.scala:2436)
[error] at sbt.Classpaths$.$anonfun$ivyBaseSettings$48(Defaults.scala:1917)
```
82b2b9e to
4668faf
Compare
dwijnand
approved these changes
Dec 15, 2017
There was a problem hiding this comment.
Sorry for the delay @mpollmeier. Yes.
I added notes as well (and rebased).
mpollmeier
added a commit
to mpollmeier/gremlin-scala
that referenced
this pull request
Dec 22, 2017
will be fixed via sbt/sbt#3760
|
The description says: so if I reverse engineer the steps would it be: steps
problemexpectationno errors. Would that be right? |
|
Your 'reverse engineer' of the problem from back then is correct, and as you said, if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with
publishArtifact := falsethe user is still forced to define a (dummy) resolver that's never used, e.g.publishTo := { Some("publishMeNot" at "https://publish/me/not") }Otherwise the following error is thrown:
Is 1.0.x the right target branch, or should it rather be 1.x?