Add sonaDeploymentName to excludeLintKeys
#8143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbt added the `sonaDeploymentName` key with sbt#8126, released with https://github.com/sbt/sbt/releases/tag/v1.11.0 - in use, this seems to be getting lint warnings (as introduced by sbt#5153): ``` [warn] there's a key that's not used by any other settings/tasks: [warn] [warn] * scala-collection-plus / sonaDeploymentName [warn] +- /home/runner/work/scala-collection-plus/scala-collection-plus/build.sbt:3 [warn] [warn] note: a setting might still be used by a command; to exclude a key from this `lintUnused` check [warn] either append it to `Global / excludeLintKeys` or call .withRank(KeyRanks.Invisible) on the key ``` https://github.com/rtyley/scala-collection-plus/actions/runs/15326291872/job/43121748535#step:6:19 ...sbt#5153 does say that "notable exceptions are settings used exclusively by a command" - I _think_ that maybe `sonaDeploymentName` is only used by the commands `sonaRelease` & `sonaUpload`, so it's necessary to add it to `excludeLintKeys`?
rtyley
added a commit
to guardian/gha-scala-library-release-workflow
that referenced
this pull request
Jun 4, 2025
https://github.com/sbt/sbt/releases/tag/v1.11.1 includes sbt/sbt#8143, which gets rid of this incorrect lint warning during our release process: ``` [warn] there's a key that's not used by any other settings/tasks: [warn] [warn] * scala-collection-plus / sonaDeploymentName [warn] +- /home/runner/work/scala-collection-plus/scala-collection-plus/build.sbt:3 [warn] [warn] note: a setting might still be used by a command; to exclude a key from this `lintUnused` check [warn] either append it to `Global / excludeLintKeys` or call .withRank(KeyRanks.Invisible) on the key ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sbtadded thesonaDeploymentNamekey with #8126, released recently with v1.11.0 - in use, this seems to be getting lint warnings (linting introduced by #5153):https://github.com/rtyley/scala-collection-plus/actions/runs/15326291872/job/43121748535#step:6:19
...#5153 does say that "notable exceptions are settings used exclusively by a command" - I think that maybe
sonaDeploymentNameis only used by the commandssonaRelease&sonaUpload, so it's necessary to add it toexcludeLintKeys?