[2.x] feat: Support glob expressions in scripted #7932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** It's currently not easy to write a scripted test that works on both sbt 1.x and 2.x when you want to write exists test under target. **Solution** Since we can only use the file system (and not evaluate Scala version etc) 1. this implements glob expression support in `exists`, `absent`, and `delete`. 2. this also introduces `||` operator that would mean a or b.
jtjeferreira
reviewed
Dec 9, 2024
There was a problem hiding this comment.
I tested this successfully by publishing both sbt 1.x and 2.x locally and using $ exists target/**/universal/simple-test-0.1.0.zip to handle both target/universal/simple-test-0.1.0.zip and target/out/jvm/scala-3.5.2/simple-test/universal/simple-test-0.1.0.zip
mzuehlke
added a commit
to mzuehlke/contraband
that referenced
this pull request
Jan 4, 2025
After support for globs in scripted tests: * sbt/sbt#7933 * sbt/sbt#7932 The changes introduced in sbt#184 can be simplified again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7931
Problem
It's currently not easy to write a scripted test that works on both sbt 1.x and 2.x when you want to write exists test under target.
Solution
Since we can only use the file system (and not evaluate Scala version etc)
exists,absent, anddelete.||operator that would mean a or b.