[1.x] Migrate all usages of System.console == null
#7843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99d1e85 to
828dc04
Compare
lihaoyi
pushed a commit
to com-lihaoyi/mill
that referenced
this pull request
Dec 27, 2024
…2 support (#4178) JDK 22 introduced some changes to the method `System.console()`: > In JDK 22, System.console() has been changed to return a Console with enhanced editing features that improve the experience of programs that use the Console API. In addition, System.console() now returns a Console object when the standard streams are redirected or connected to a virtual terminal. Prior to JDK 22, System.console() instead returned null for these cases. This change may impact code that checks the return from System.console() to test if the JVM is connected to a terminal. If required, the -Djdk.console=java.base flag will restore the old behavior where the console is only returned when it is connected to a terminal. Starting JDK 22, one could also use the new Console.isTerminal() method to test if the console is connected to a terminal. Mill assumes the old behavior of `System.console` and use `System.console() != null` to check if we have interactive console, causing issue like #4161. This PR added universal availability check for an interactive console, compatible with JDK < 22 and later. SBT made similar changes in sbt/sbt#7843. Closes #4161 --------- Co-authored-by: Nikolay Artamonov <n.artamonov@sigma-it.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
nartamonov pointed out that JDK 22 changed the behavior of
System.consolein #7580.sbtassumes the old behavior ofSystem.consoleand useSystem.console == nullto check if connection to terminal exists, causing issue like #7580 and #7841Solution
We reflectively call
Console.isTerminal()if it exists, otherwise fall back to JDK 8System.console == nullcomparison.Closes #7841
Closes #7842