Skip to content

[1.x] Submit dependency graph for security alert & Fix CI #7746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

Friendseeker
Copy link
Member

@Friendseeker Friendseeker commented Oct 9, 2024

We have the dependency submission mechanism, but the branch name used is wrong, hence dependency graph on 1.10.x branch is never submitted.

This PR fixes the branch name

Also fixes CI failures due to sbt command not found

@Friendseeker Friendseeker requested review from eed3si9n and adpi2 October 9, 2024 17:45
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add develop in there too?

@Friendseeker
Copy link
Member Author

Friendseeker commented Oct 9, 2024

Shall do it. Btw going slightly offtopic, why are CI failing... This PR just patched an existing CI job.

I do feel like there might be something gravely wrong with the CI runs for which we need to investigate. It is probably a mix of many issues.

When existing CIs are flaky it makes bump CI to JDK 21 harder as we will not able to easily tell which CI failures are introduced after bumping JDK and which failures are always there.

@Friendseeker Friendseeker changed the title [1.x] Submit dependency graph for security alert [1.x] Submit dependency graph for security alert & Fix CI Oct 9, 2024
Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 26a7762 into sbt:1.10.x Oct 9, 2024
10 checks passed
@Friendseeker Friendseeker deleted the dependency-res-bump branch October 9, 2024 20:36
Friendseeker added a commit to Friendseeker/sbt that referenced this pull request Oct 10, 2024
Friendseeker added a commit to Friendseeker/sbt that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants