[1.x] Bump jline3 to 3.27.0
#7695
Conversation
Bump native image options Try use Github Action to setup GraalVM Update native image version Update java version to be in sync with Native Image Plugin Try anything Create the dir to place native image Try again Remove Graal setup Believe in couriser?
| nativeImageVersion := "23.0", | ||
| nativeImageJvm := "graalvm-java23", | ||
| nativeImageOutput := { | ||
| val outputDir = (target.value / "bin").toPath |
There was a problem hiding this comment.
Without explicitly creating the dir there, the following Error is thrown
Error: Writing image to non-existent directory /Users/runner/work/sbt/sbt/client/target/bin is not allowed. Create the missing directory if you want the image to be written to that location.
Example: https://github.com/Friendseeker/sbt/actions/runs/11008291362/job/30565658216
|
@SethTisue I got the native image jobs to work and made this PR based on top of your work (#7500). Would you like to quickly take a look at this PR and see if things look alright? The issue is that I know nothing about jline or sbt terminal implementation, so need someone with domain expertise like you to proceed with the PR. |
3.27.03.27.0
|
I can have a look next week. |
|
LGTM, not that I brought any particular expertise to bear on it 😁 I guess what happened here is that JDK 23 went GA since I tried this, and so the trouble I hit simply doesn't exist anymore. @eed3si9n wdyt? I've submitted scala/scala#10882 to scala/scala, and I'll do Scala 3 soon (UPDATE: here 'tis: scala/scala3#21752) |
the same upgrade is in flight in these other repos: * scala/scala#10882 * sbt/sbt#7695 JLine release notes: * https://github.com/jline/jline3/releases/tag/jline-3.27.0 * https://github.com/java-native-access/jna/blob/master/CHANGES.md#release-5150 a lot of bugfixes, nothing really stands out that I can see we usually take these upgrades in the hopes they will improve things in small ways, especially for Windows users I verified that the `repl` command inside our sbt build still works (on MacOS anyway)
Fixes #7505
c.c. https://discord.com/channels/632150470000902164/922600050989875282/1287082148037132378