Include ALL sources, and resources in source jar #7630
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows on from sbt#7470, to include all sources, not just managed and unmanaged, in the source jar, along with all resources (previously only unmanaged resources were included). This means that if, for whatever crazy reason, someone does modify the `sources` task to include additional sources or filter out sources, rather than using the managed or unmanaged source mechanisms, their changes will still be reflected in the source jar.
This was referenced Aug 26, 2024
raboof
added a commit
to raboof/sbt-apache-sonatype
that referenced
this pull request
Sep 22, 2024
Fixes mdedetrich#39 In sbt 1.10.2 the managed resources are automatically included in the packageSrc (sbt/sbt#7630), and doing it again explicitly causes errors.
mdedetrich
pushed a commit
to mdedetrich/sbt-apache-sonatype
that referenced
this pull request
Sep 23, 2024
Fixes #39 In sbt 1.10.2 the managed resources are automatically included in the packageSrc (sbt/sbt#7630), and doing it again explicitly causes errors.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on from #7470, to include all sources, not just managed and unmanaged, in the source jar, along with all resources (previously only unmanaged resources were included).
This means that if, for whatever crazy reason, someone does modify the
sourcestask to include additional sources or filter out sources, rather than using the managed or unmanaged source mechanisms, their changes will still be reflected in the source jar. It ensures consistency with bothcompileanddoc, which both also depend onsourcesrather than manually gatheringunmanagedSourcesandmanagedSourcesthemselves.