Add support for wildcards in Scala version switch (fuzzy switch) #6894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raboof I am thinking about wrapping up 1.7.0 soon. |
3198cab to
b4b0e5f
Compare
Thanks for the ping, added tests (and fixed behavior), now ready for review. |
|
(rebased on |
257b333 to
ee83457
Compare
Picking from the `crossScalaVersions` As discussed in sbt#6893
|
1.7.x branch would be better but either is ok. |
This was referenced Jun 24, 2022
|
this is awesome. I love it! a small suggestion. the output is: but it doesn't tell me which version it actually selected; I'd prefer not to have to |
raboof
added a commit
to raboof/sbt
that referenced
this pull request
Jun 28, 2022
Suggested by @SethTisue in sbt#6894 (comment) Will show multiple lines when different versions are selected for different subprojects. When no subprojects have a matching Scala version you will get a 'Switch failed' exception anyway, so in that case there is no change in behavior.
This was referenced Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to use semantic version selector expression (such as
2.13.xand3.x) in++command as discussed in #6893. The following description includes the patch in #6936.Usage
Explanation
This is an extension of existing
++ <sv> <command1>where the given<command1>will be executed only within the subprojects listing<sv>in their respectivecrossScalaVersionssetting.sbt 1.7.0 now allows the
<sv>part to be a semantic version selector expression, implemented originally by @tanishiking in sbt/librarymanagement#239 based on npm-semver. Note that the semantic version selector expression may match at most one Scala version withincrossScalaVersionsper subproject. This is because++remains to be a switch command.