Skip to content

Conversation

github-samuel-clarenc
Copy link
Contributor

Fixes #6548

This tiny PR adds the "integration-test" tag to the IntegrationTest configuration when using BSP

@lightbend-cla-validator

Hi @samuelClarencTeads,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

https://www.lightbend.com/contribute/cla

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samuelClarencTeads!

@adpi2
Copy link
Member

adpi2 commented Jun 17, 2021

I don't know how to run the CLA validation again but @eed3si9n will probably be able to merge the PR anyway.

Copy link
Member

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eed3si9n eed3si9n merged commit 4926cb4 into sbt:develop Jun 17, 2021
sebastian-alfers added a commit to sebastian-alfers/sbt that referenced this pull request Jun 20, 2021
Merge pull request sbt#6551 from samuelClarencTeads/bspIntegrationTestTag

Add the tag "integration-test" to the it configuration in BSP.
fixes remote caching not managing resource files

What is the problem?
When using remote caching, the resource files are not tracked so if they
have changed, pullRemoteCache will deliver both the old resource file
as well as the changed one.

This is a problem, because it's not the behaviour that our users will
expect and it's not in keeping with the contract of this feature.

Why is this happening?
Zinc, sbt's incremental compiler, keeps track of changes that have
been made. It keeps this in what is called the Analysis file.
However, resource files are not tracked in the Analysis file, so
remote caching is not invalidating the unchanged resource file in
place of the latest version.

What is the solution?
PullRemoteCache deletes all of the resources files. After this,
copyResources is called by PackageBin, which puts the latest
version of the resources back.

Merge branch 'develop' into remote-cache
Merge pull request sbt#6554 from Nirvikalpa108/remote-cache

fixes remote caching not managing resource files
Merge branch 'develop' into restore-charridge-return
cleanup spec;

Merge branch 'restore-charridge-return' of github.com:sebastian-alfers/sbt into restore-charridge-return
@eed3si9n eed3si9n changed the title Add the tag "integration-test" to the it configuration in BSP. Fixes IntegrationTest configuration not tagged as test in BSP Jul 12, 2021
@eed3si9n eed3si9n added this to the 1.5.5 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BSP] - IntegrationTest configuration not tagged as test
4 participants