Move scalaInstanceTopLoader to compileBase settings #6480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43124be to
aeb5fd9
Compare
|
I haven't branched out develop to 1.5.x yet. Is this more of a 1.6.0-M1 feature or can this be "backported" to 1.5.x without going through the RC cycle? |
|
It is not forward compatible because I changed the scope of I can backport a lighter version, that just makes |
|
Maybe we can merge #6481 and put this one on hold for now. |
eed3si9n
added a commit
that referenced
this pull request
May 3, 2021
Backport #6480: Expose makeScalaInstance publicly
|
@eed3si9n This one should be ready to merge. |
eed3si9n
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
scalaInstanceTopLoaderanduseScalaReplJLinetocompileBase:They are/should only be used in the
JvmPluginto create thescalaInstance.Move
jansiExclusionLoader(for Scala 2.10 only) to thescalaInstanceTopLoaderimplementationRemove the
ClassLoaderCachehack for dotty:It is not needed anymore, since dotty uses sbt 1.5
Make
Defaults.makeScalaInstancepublic:ScalaInstanceand thescalaInstancetask are public. But, to create a customscalaInstancewe need theextendedClassLoaderCachewhich is package private. That's why I thinkmakeScalaInstanceshould be public.This will allow us to properly bootstrap the Scala compiler in the dotty repository. See scala/scala3#12259.