[1.4.x] JLine 3.19.0 #6366
Merged
[1.4.x] JLine 3.19.0 #6366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The launcher embeds a fixed version of jansi above the rest of the classpath on windows. This causes problems for the scala 2.12 console because it tries to load methods that don't exist from the old jansi jar. This can be fixed by excluding all jansi classes from the top loader. We also need to exclude jansi classes in the scala instance top class loader to make the 2.10 console work because scala 2.10 uses a shaded jline that requires a very old jansi version. Due to the shading, the thin client doesn't work with the 2.10 console.
We no longer need to use the forked version of jline because they have merged in our required changes. The latest version of jline does upgrade jansi, however, and some of the apis we were relying on for windows were removed so they had to be manually implemented. I verified that console input still worked on my windows vm after this change.
Fixes sbt#6348 Intentionally or unintentionally the JLine 3 leaks over from sbt to Scala REPL currently. I think this enables things like sbtn to transmit tab completion and other console interaction over a socket to sbt server. Scala 2.13.5 REPL now causes some issue of displaying warning each time the user hits tab for tab completion. This works around the issue by upgrading to the latest JLine 3.
griggt
added a commit
to griggt/dotty
that referenced
this pull request
Mar 12, 2021
Aligns with Scala 2.13.5: scala/scala#9467 and sbt 1.4.8: sbt/sbt#6366 Fixes scala#11488
michelou
pushed a commit
to michelou/scala3
that referenced
this pull request
Mar 15, 2021
Aligns with Scala 2.13.5: scala/scala#9467 and sbt 1.4.8: sbt/sbt#6366 Fixes scala#11488
romanowski
pushed a commit
to BarkingBad/dotty
that referenced
this pull request
Mar 23, 2021
Aligns with Scala 2.13.5: scala/scala#9467 and sbt 1.4.8: sbt/sbt#6366 Fixes scala#11488
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6348
Intentionally or unintentionally the JLine 3 leaks over from sbt to
Scala REPL currently.
I think this enables things like sbtn to transmit tab completion and
other console interaction over a socket to sbt server.
Scala 2.13.5 REPL now causes some issue of displaying warning
each time the user hits tab for tab completion.
This works around the issue by upgrading to the latest JLine 3.