Reduce overhead by 90% #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamird
added a commit
to cockroachdb/vendored
that referenced
this pull request
Dec 1, 2016
Temporarily use https://github.com/tamird/go-deadlock to pick up sasha-s/go-deadlock#2. Tons of changes to staticcheck, but nothing new was flagged. See dominikh/go-staticcheck@1808e1b...66144fd
This was referenced Dec 1, 2016
This reduces runtime overhead by about 45% in CockroachDB.
This reduces runtime overhead by about 80% in CockroachDB.
|
Thanks, looks great, Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
@sasha-s can you cut a release containing this (or remove the other release)? Currently https://github.com/golang/dep picks up the only other release which is unusably slow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while investigating why our tests were terribly slow when using go-deadlock in CockroachDB.
cc @petermattis
This change is