Complete #1631: typia.llm.application supports custom validation hook.
#1632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces custom validation hook support for LLM applications and controllers, allowing users to provide custom validation functions for each API method. Additionally, it updates dependencies and improves various schema documentation and test outputs.
- Added
validateoption toILlmApplication.IOptionsenabling custom validation functions per method - Updated
@samchon/openapidependency from version 4.6.0 to 4.7.1 - Improved schema documentation clarity and fixed type ordering in test schemas
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/llm.ts | Extended options type to include validate parameter for application and controller functions |
| src/internal/_llmApplicationFinalize.ts | Added validation hook assignment logic and type definitions |
| src/transformers/features/llm/LlmApplicationTransformer.ts | Modified transformer to support validate option alongside separate |
| test/src/features/issues/test_issue_1631_llm_application_custom_validate.ts | New test demonstrating custom validation functionality |
| test/src/debug/llm.ts | Refactored debug code to use proper function structure |
| test/schemas/reflect/metadata/TypeTagTypeUnion.json | Fixed ordering and schema details for int32/uint32 types |
| Various schema files | Updated documentation descriptions for better clarity |
| package.json | Version bump and dependency update |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
test/src/features/issues/test_issue_1631_llm_application_custom_validate.ts
Show resolved
Hide resolved
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for a new
validateoption in the LLM application/controller APIs, updates dependencies, and makes several improvements and corrections to the codebase and test schemas. The most important changes are grouped below:Feature: Add
validateoption to LLM APIsAdded support for a
validateoption inILlmApplication.IOptions, allowing per-function validation logic to be attached and invoked within LLM applications and controllers (src/internal/_llmApplicationFinalize.ts,src/llm.ts,src/transformers/features/llm/LlmApplicationTransformer.ts). [1] [2] [3] [4] [5] [6] [7] [8]Updated test code to exercise and demonstrate the new
validatelogic for LLM controllers (test/src/debug/llm.ts). [1] [2]Dependency updates
@samchon/openapifrom version4.6.0to4.7.1in bothpackage.jsonand lockfile, ensuring compatibility with new features. [1] [2] [3] [4]Other improvements and corrections
9.7.0-dev.20250805inpackage.json.Type<"int32">andType<"uint32">inTypeTagTypeUnion.jsontest schema. [1] [2]