Skip to content

Conversation

Sahilb315
Copy link
Contributor

No description provided.

@Sahilb315 Sahilb315 changed the title use tag version instead of commit hash Fix SLSA CI Failing Aug 11, 2025
@Sahilb315 Sahilb315 requested a review from abhisek August 11, 2025 09:47
@Sahilb315
Copy link
Contributor Author

SLSA allows only using of tags as version instead of any commit hashes.
https://github.com/slsa-framework/slsa-github-generator?tab=readme-ov-file#referencing-slsa-builders-and-generators

image_720

@Sahilb315 Sahilb315 linked an issue Aug 11, 2025 that may be closed by this pull request
@abhisek
Copy link
Member

abhisek commented Aug 11, 2025

@Sahilb315 LGTM. But this is weird. How come the workflow works with tag and not with hash? Something to explore.

Update: Never mind. I see the docs that you provided.

@abhisek abhisek enabled auto-merge (squash) August 11, 2025 12:14
@abhisek abhisek merged commit 7d4569f into main Aug 11, 2025
10 of 12 checks passed
@abhisek abhisek deleted the fix/#462-slsa-ci-failing branch August 11, 2025 12:14
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 8.35%. Comparing base (47939fa) to head (1f691b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #557   +/-   ##
=====================================
  Coverage   8.35%   8.35%           
=====================================
  Files        280     280           
  Lines      45973   45973           
=====================================
  Hits        3839    3839           
  Misses     41856   41856           
  Partials     278     278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sahilb315 added a commit that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI failing, upload SLSA
2 participants