Closes #274: Revert on failure with safeTxGas 0 #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmeissner
commented
Mar 23, 2021
Uxio0
approved these changes
Mar 23, 2021
| @@ -170,6 +170,8 @@ contract GnosisSafe | |||
| // We only substract 2500 (compared to the 3000 before) to ensure that the amount passed is still higher than safeTxGas | |||
| success = execute(to, value, data, operation, gasPrice == 0 ? (gasleft() - 2500) : safeTxGas); | |||
| gasUsed = gasUsed.sub(gasleft()); | |||
| // If no safeTxGas and no gasPrice was set (e.g. both are 0), then the internal tx is required to be successful | |||
There was a problem hiding this comment.
Maybe it can be added to the comment that this behaviour is implemented due to the optimistic estimation of ethereum providers
Uxio0
pushed a commit
that referenced
this pull request
May 6, 2021
Saw-mon-and-Natalie
pushed a commit
to Saw-mon-and-Natalie/safe-contracts
that referenced
this pull request
Nov 1, 2023
fdarian
pushed a commit
to fdarian/safe-contracts
that referenced
this pull request
Jan 14, 2024
Update safe-ethers-adapters README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #274
Revert on failure if
safeTxGas == 0andgasPrice == 0Notes:
safeTxGasis set to 1 you get the previous behaviour