Skip to content

If safeTxGas is 0 the tx should be reverted on failure #274

@rmeissner

Description

@rmeissner

Description

We do not revert if a Safe transaction fails to be able to invalidate the nonce. This is especially important if we use a relay service. In this case it is also important that a proper safeTxGas is set so that the relayer is required to sent enough gas.

In cases where no safeTxGas is sent (aka it is 0) the relayer functionality of the Safe contracts should therefore not be used. If we assume that the transaction is not executed by a relayer (e.g. an owner) we should revert on failure.

Considerations

To ensure that this is only applied when no relayer is used the gasPrice should also be required to be 0

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions