Skip to content

Conversation

TiceCosmos
Copy link
Contributor

Copy link
Owner

@sagiegurari sagiegurari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TiceCosmos amazing work. never used meson before so my knowledge there is a bit limited, but overall looks really great and would love to merge it.

@TiceCosmos TiceCosmos requested a review from sagiegurari June 23, 2021 01:26
Copy link
Owner

@sagiegurari sagiegurari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome. few small stuff and we are good to go.

@TiceCosmos TiceCosmos requested a review from sagiegurari June 24, 2021 03:49
@sagiegurari
Copy link
Owner

@TiceCosmos looks great. i have approved it.
i just got 1 last question about CARGO_MAKE_MESON_ARGS there, so tell me what you think and then i'll merge the PR.

@sagiegurari
Copy link
Owner

@TiceCosmos merging. thanks a lot for the PR!!!

@sagiegurari sagiegurari merged commit 78ef8c2 into sagiegurari:master Jun 25, 2021
sagiegurari added a commit that referenced this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants