Skip to content

Conversation

dkrenn
Copy link
Contributor

@dkrenn dkrenn commented Aug 3, 2023

Implements an algorithm to check for boundedness of k-regular sequences. See issue #22964.

(Coding and reviewing already happend on trac (see #22964) and the branch was ready but never merged due to a trivial issue. Now the current develop (10.1.beta8) has been merged in to avoid conflicts the upcoming #36011 (where a renaming took place; set as depedency now).

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

dkrenn and others added 30 commits August 25, 2016 13:37
* commit '5919120': (102 commits)
  doctesting all parameters in coefficient_of_word
  pass keywords to coefficient_of_word
  experimental warning in k_regular_sequence
  minor rewrite in minimized
  flag to skip multiplication with left/right
  update __getitem__ to follow recognizable series
  rearrange __getitem__
  put conversion code n --> index/word into separat method
  fix a typo
  fix doctests
  add experimental warning
  extend element constructor
  remove None-sense to simplify code
  correct one link
  move "transpose" in docstring to correct place
  cross-references
  complete docstrings and 100% coverage
  complete documentation
  reorder imports
  coverage to 100%
  ...
* t/21203/sequences/k-regular: (1891 commits)
  fix building of docs (no idea why it failed)
  fix doctests (experimental warning)
  Updated SageMath version to 7.4.beta1
  Dots removed.
  Minor changes.
  More cleanup
  Add sphinx plots and cleanup
  Fix doctests and minor cleanup
  Corrections, changes etc.
  Trac sagemath#21181: Yet a few more formatting fixes in docstrings of sage/combinat/words/finite_word.py
  Trac sagemath#21181 (previously sagemath#21178): Change to imperative form in docstrings of sage/combinat/words/finite_word.py, part II
  Trac sagemath#21181 (previously sagemath#21178): Change to imperative form in docstrings of sage/combinat/words/finite_word.py
  Trac sagemath#21178: A few more markup/formatting fixes in docstrings of sage/combinat/words/finite_word.py
  Trac sagemath#21178: Fix typos and a lot of markup/formatting in docstrings of sage/combinat/words/finite_word.py
  py3: no longer use file(name, kind)
  21137: minor doc change
  sqome more typos
  trac 21241 details
  Fix formatting
  trac 21241 typo in faq (preparser)
  ...
…ar-trunk

* t/21318/sequences/rec-basic-arith:
  factor out subsequence to separat ticket
  extend to negative shifts in subsequence
  doctesting rmul, lmul and one_hadamard
  doctesting all parameters in coefficient_of_word
  subsequence
  hadamard_product
  change category to modules
  _rmul_ and _lmul_
  _neg_
  _add_
  dimension
* t/21319/sequences/rec-hash:
  equality testing
  hashing
  mutability in transposed()
  fix doctests
  handle mutable structures
…lar-trunk

* t/21325/sequences/k-regular-subseq:
  minor rewrites to use existing stuff better
  partial sums
  minor rewrites
  forward/backward difference
  allow b to be a dict
  minor rewrite
  rewrite to make subsequence more efficient (dynamically add kernel)
  quasi-cherry-pick of pad_right of k-regular-guess branch
  missing_value=0
  subsequence
…ar-trunk

* t/21204/sequences/k-regular-guess:
  another example
  solve transpositioning problem
  simplify code by using features of recognizable series better (and adapting to removing None-sense)
  fix code and doctests to adapt with upstream recognizable series
  post-merge Änderungen
  switch to Python's logging
  docstring of pad_right
  one linebreak to avoid a long line
  function "split_interlace"
  function "value"
  method for guessing k-regular sequences
* t/21319/sequences/rec-hash:
  TestSuite
  pickling support
  an_element and some_elements
  FreeModule_generic.some_elements
  MatrixSpace.some_elements
…ar-trunk

* t/21204/sequences/k-regular-guess:
  finish .guess (docstrings etc)
  doctests
  guessing partial sums
* t/21343/k-regular-warning:
  add some doctests related to health
  equip element constructor with a warning
  use logging more correctly
  methods for dealing with healthyness
  correct creation of element in transposed
  remove zero()
  some doctests
  activate logging
* t/21343/k-regular-warning: (156 commits)
  minor correction in doc
  remove zero()
  solve troubles with doc-building
  solve troubles with doc-building
  minor correction in doc
  add some doctests related to health
  equip element constructor with a warning
  use logging more correctly
  methods for dealing with healthyness
  correct creation of element in transposed
  remove zero()
  Updated SageMath version to 7.4.beta2
  finish .guess (docstrings etc)
  some doctests
  activate logging
  doctests
  TestSuite
  pickling support
  an_element and some_elements
  FreeModule_generic.some_elements
  ...
…o t/21202/k-regular-trunk

* 'u/dkrenn/k-regular-trunk' of trac.sagemath.org:sage:
SageMath version 7.4.beta3

* tag '7.4.beta3': (323 commits)
  Updated SageMath version to 7.4.beta3
  Mark package tests as random
  trac 21364 detail
  hash doctest as per reviewer's suggestion
  fix for base ring in monomial bases in LLT class
  trac 21364 get rid of imap
  fix doc building error
  add pacth fixing the gcc <= 4.9.2 issue by leif.
  Fix format
  trac 21351 correct wrong code
  trac 21338 removing seealsos
  Make canonical_label use a set algorithm for consistency.
  fix TypeError: can't use a string pattern on a bytes-like object
  moved sage.modules.binary_search to sage.data_structures.binary_search
  Add appnope package
  21326: Remove trailaing spaces [reviewer]
  reinstate as per reviewer's insistence
  I changed a doctest that was broken.
  Convert .pxi files in sage/modules/ into proper .pxd/.pyx files
  Restore --without-fink that was lost
  ...
* t/21343/k-regular-warning: (1709 commits)
  fix doctest output of TestSuite (new tests were added)
  Python3: fix iteritems
  Python3: xrange
  Python3: absolut import
  Python3: absolute import
  Python3: izip
  Python3: __nonzero__
  Trac sagemath#21295: fix typos
  Trac sagemath#21295: fix ReST error
  Updated SageMath version to 7.5
  Updated SageMath version to 7.5.rc3
  Use a deterministic sorting key for number fields
  Updated SageMath version to 7.5.rc2
  22136: pkg version/chksum
  Upgrade to Python 2.7.13
  Updated SageMath version to 7.5.rc1
  amending coment and message in setup.py
  Move autogen to a more appropriate location.
  22095: better doctest
  run tests only in spkg-check. Also run spkg-check with the same options as spkg-install
  ...
@dkrenn
Copy link
Contributor Author

dkrenn commented Aug 3, 2023

CC @cheuberg

Copy link
Contributor

@cheuberg cheuberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this has originally been written by @galipnik and reviewed by @dkrenn. I reviewed the changes since the last conversation between the two on #22964 (mostly merges and minor adjustments of doctests).

However, due to one broken link, I could not have a look at the documentation of the new module; so @dkrenn could you perhaps fix that broken link first and then I'll have a look at the documentation of the new module? Thank you.

dkrenn added 3 commits August 24, 2023 11:54
SageMath version 10.1, Release Date: 2023-08-20

* tag '10.1': (300 commits)
  Updated SageMath version to 10.1
  Updated SageMath version to 10.1.rc0
  src/sage/rings/finite_rings/residue_field.pyx: Make a doctest work when another impl is used
  use block level tag
  src/sage/tests/book_stein_ent.py: Update doctest continuation format
  src/sage/dynamics/arithmetic_dynamics/wehlerK3.py: Fix bad use of line continuation
  src/sage/coding: Fix uses of '...' that only worked by accident
  src/sage/doctest/parsing.py: Remove '...' continuation line pattern from backslash replacer
  src/sage/symbolic/expression.pyx: Fix bad use of line continuation
  src/sage/doctest/parsing.py: Add test
  src/sage/doctest/parsing.py: Do not insert extra newline when handling doctest line continuations
  fix doctest warnings in sage.graphs
  src/sage/rings/finite_rings/conway_polynomials.py: Fix # needs
  remove deprecated parameter circular in planarity.pyx
  remove rename warning in spanning_tree.pyx introduced in 32805
  remove deprecation 32238 from bipartite_graph.py
  remove deprecation 32238
  remove deprecation 32222
  remove import that is no longer used
  stop sorting graph vertices by default
  ...
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Documentation preview for this PR (built with commit 69dfac1; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@cheuberg cheuberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scrolled through the documentation and made a few remarks.

dkrenn and others added 8 commits February 24, 2025 16:45
SageMath version 10.5, Release Date: 2024-12-04

* tag '10.5': (10166 commits)
  Updated SageMath version to 10.5
  PKG_CONFIG must be empty if not found
  Updated SageMath version to 10.5.rc2
  the patch breaks some macOS installations
  Fix meson build by adding missing python files
  Updated SageMath version to 10.5.rc1
  Do not upload logs artifact for the default job
  Add a small improvement
  Materialize literal-blocks list before modifying nodes
  Python3 build does not find openssl without pkgconf
  Updated SageMath version to 10.5.rc0
  30751 iteration over infinite groups
  build/pkgs/python3/spkg-configure.m4: delete cygwin case
  build/pkgs/sqlite/spkg-configure.m4: drop cygwin case
  src/doc/en/developer/portability_testing.rst: don't mention cygwin.txt
  build/pkgs: delete all cygwin.txt files
  build/bin/sage-spkg-info: drop cygwin case
  build/bin/sage-print-system-package-command: drop cygwin cases
  build/bin/sage-guess-package-system: drop cygwin case
  Avoid non-invertible scaling and zero endomorphism
  ...
Co-authored-by: cheuberg <clemens.heuberger@aau.at>
Co-authored-by: Gabriel Lipnik <mail@gabriellipnik.at>
…ular-bounded

* 'k-regular-bounded' of github.com:dkrenn/sage:
  fix early return by mandel/simon-algo
  Typo TESTS
@dkrenn dkrenn requested a review from cheuberg February 25, 2025 15:20
@dkrenn
Copy link
Contributor Author

dkrenn commented Feb 25, 2025

test-long failed unrelatedly to the changes of this PR and should somehow (don't know how) be restarted.

Co-authored-by: cheuberg <clemens.heuberger@aau.at>
Copy link
Contributor

@cheuberg cheuberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Positive Review.

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 1, 2025
sagemathgh-36029: k-regular sequences: boundedness
    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

Implements an algorithm to check for boundedness of k-regular sequences.
See issue sagemath#22964.

(Coding and reviewing already happend on trac (see sagemath#22964) and the
branch was ready but never merged due to a trivial issue. Now the
current develop (10.1.beta8) has been merged in to avoid conflicts the
upcoming sagemath#36011 (where a renaming took place; set as depedency now).

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

- sagemath#36011: Experimental warning removed in class used in this PR and
class was renamed.
    
URL: sagemath#36029
Reported by: Daniel Krenn
Reviewer(s): cheuberg, Daniel Krenn, Gabriel Lipnik
@vbraun vbraun merged commit 6ca04f7 into sagemath:develop Apr 2, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants