Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 17, 2023

📚 Description

To fix build on fedora-39-minimal, archlinux-latest-{minimal,standard}, opensuse-tumbleweed-minimal - as seen in https://github.com/scipopt/SCIP-SDP/actions/runs/5203680653 (scipopt/SCIP-SDP#6)

Tests at https://github.com/mkoeppe/SCIP-SDP/actions/runs/5298512526

Part of:

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 17, 2023

Failure for archlinux-latest-standard (https://github.com/mkoeppe/SCIP-SDP/actions/runs/5298512526/jobs/9590920290#step:13:203):

In file included from /sage/local/var/tmp/sage/build/onetbb-2021.9.0/src/test/tbbmalloc/test_malloc_lib_unload.cpp:21:
/sage/local/var/tmp/sage/build/onetbb-2021.9.0/src/test/common/utils_assert.h: In function 'void utils::ReportError(const char*, int, const char*, const char*)':
/sage/local/var/tmp/sage/build/onetbb-2021.9.0/src/test/common/utils_assert.h:37:5: error: 'abort' was not declared in this scope
   37 |     abort();
      |     ^~~~~
/sage/local/var/tmp/sage/build/onetbb-2021.9.0/src/test/common/utils_assert.h:22:1: note: 'abort' is defined in header '<cstdlib>'; did you forget to '#include <cstdlib>'?
   21 | #include "utils_report.h"
  +++ |+#include <cstdlib>
   22 | 

@github-actions
Copy link

Documentation preview for this PR (built with commit d39809b) is ready! 🎉

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 17, 2023

This fixes the onetbb build on all Linux platforms (except for ubuntu-trusty, which is hopeless)

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 28, 2023

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 1, 2023
sagemathgh-35786: onetbb: Upgrade to 2021.9.0 + GCC13 patch
    
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes sagemath#12345", use "Add a new method to
multiply two integers" -->

### 📚 Description

<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
To fix build on fedora-39-minimal, archlinux-latest-{minimal,standard},
opensuse-tumbleweed-minimal - as seen in
https://github.com/scipopt/SCIP-SDP/actions/runs/5203680653
(scipopt/SCIP-SDP#6)

Tests at https://github.com/mkoeppe/SCIP-SDP/actions/runs/5298512526
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
Part of:
-  sagemath#35092

<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->
- Depends on sagemath#35785 (merged here)

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#35786
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik
@vbraun vbraun merged commit fdf30fb into sagemath:develop Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants