avoid using bytes_to_str in matrix/ (pyx files) #40072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit f5b981f; changes) is ready! 🎉 |
dcoudert
approved these changes
May 8, 2025
There was a problem hiding this comment.
LGTM.
The doctest error https://github.com/sagemath/sage/actions/runs/14907665722/job/41873834390?pr=40072#step:12:6266 is independent from this PR and the issue has already been reported in #39807 / #39837.
|
back to positive after trivial merge |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2025
<using instead the builtin `encode` or `decode` methods. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#40072 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<using instead the builtin
encodeordecodemethods.📝 Checklist