Skip to content

free_module_pseudomorphism equality checking test failure #39807

@user202729

Description

@user202729

Steps To Reproduce

on CI:

            sage: g = V.pseudohom(m.transpose(), Frob)
            sage: f == g
 Check failure on line 483 in src/sage/modules/free_module_pseudomorphism.py


GitHub Actions
/ Conda (ubuntu, Python 3.12)
Failed example:
Failed example:: Got: True

Looks like __eq__ forgets to check that the side are equal. @xcaruso ?

added in #38650


Side note: __lt__ etc. (fallback from _richcmp_) are not overridden. Is this intentional? (e.g. is trichotomy ever violated?)

Another bug: __eq__ returns None if wrong type (surely it shouldn't return None right, it should return NotImplemented).

Expected Behavior

Actual Behavior

Additional Information

No response

Environment

CI, latest

Checklist

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
  • I have read the documentation and troubleshoot guide

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions