Wildcard file inotify #5315
Merged
Wildcard file inotify #5315
+118
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15e3640 to
b7d0128
Compare
9104fa6 to
0b30985
Compare
…at cannot be split as it is an event handler callback) Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Hofi <hofione@gmail.com>
… is set before trying to call it Signed-off-by: Hofi <hofione@gmail.com>
…obs if its new notified member set to TRUE This can be used whereas a PollEvents object is required and cannot be NULL, but its functionality is not needed at all, e.g in the file_reader, where the watched file modification events can be detected and delivered in other ways. Far not the best solution, but PollEvents is too deeply integrated currently, and I did not want to do an even bigger refactor. Signed-off-by: Hofi <hofione@gmail.com>
…we do it for the directory monitor Signed-off-by: Hofi <hofione@gmail.com>
… using the poll_events provided ones Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Hofi <hofione@gmail.com>
…on events Signed-off-by: Hofi <hofione@gmail.com>
…ot use poll_events Signed-off-by: Hofi <hofione@gmail.com>
…he reader Signed-off-by: Hofi <hofione@gmail.com>
0b30985 to
68b62c7
Compare
…le to display the real_path in the starting log message Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Hofi <hofione@gmail.com>
Signed-off-by: Hofi <hofione@gmail.com>
68b62c7 to
17a716d
Compare
therandomstring
approved these changes
Apr 11, 2025
HofiOne
added a commit
to syslog-ng/syslog-ng.github.io
that referenced
this pull request
Apr 11, 2025
Changes introduced in, and depends on syslog-ng/syslog-ng#5315, syslog-ng/syslog-ng#5312 Signed-off-by: Hofi <hofione@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wildcard-file: Added inotify-based regular file change detection using the existing inotify-based directory monitor.This improves efficiency on OSes like Linux, where only polling was available before, significantly reducing CPU usage while enhancing change detection accuracy.
To enable this feature, inotify kernel support is required, along with
monitor-method()set toinotifyorauto, andfollow-freq()set to 0.This PR will have a follow-up pair as we have to fix the full-path handling in the file-reader and the directory monitor which is really messy. FIXME notes will be removed in the next round.
Doc PR syslog-ng/syslog-ng.github.io#185
Resolves: #5019
Signed-off-by: Hofi hofione@gmail.com