S3 bugfix and refactor #5257
Merged
S3 bugfix and refactor #5257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hon destination were to be writing a log simultaneously Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
…ng() calls Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
The backfill behaviour will be replaced with a simpler solution in a later commit on this branch. Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
|
Build FAILURE |
4 similar comments
|
Build FAILURE |
|
Build FAILURE |
|
Build FAILURE |
|
Build FAILURE |
79bfa7f to
f65d5b5
Compare
|
Build FAILURE |
1 similar comment
|
Build FAILURE |
26b4b07 to
30abe44
Compare
|
Build FAILURE |
therandomstring
added a commit
to therandomstring/syslog-ng
that referenced
this pull request
Mar 12, 2025
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
|
Build FAILURE |
kovgeri01
requested changes
Mar 17, 2025
modules/python-modules/syslogng/modules/s3/s3_session_handler.py
Outdated
Show resolved
Hide resolved
modules/python-modules/syslogng/modules/s3/s3_session_handler.py
Outdated
Show resolved
Hide resolved
modules/python-modules/syslogng/modules/s3/s3_session_handler.py
Outdated
Show resolved
Hide resolved
|
@kovgeri01 I reworked the locks. Could you do another review round with them in mind? |
11abb05 to
8864eb8
Compare
These introduce simpler, easier to maintain replacements to the S3Object class. The new classes also help with separation of concern. Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
…lasses Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
Some dependencies (however unlikely) may not be installed, resulting in syslog-ng crashing. This should eliminate that concern. Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
This commit temporarily disables the upload-on-close behaviour. It will be reintroduced later. Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
… and shutdown This commit reintroduces the removed upload-on-close behaviour and replaces the old backfill. Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
kovgeri01
approved these changes
Mar 19, 2025
e902103 to
93e34f1
Compare
|
Build FAILURE |
therandomstring
added a commit
to therandomstring/syslog-ng
that referenced
this pull request
Mar 20, 2025
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com> (cherry picked from commit 7dd4145)
HofiOne
pushed a commit
to HofiOne/syslog-ng
that referenced
this pull request
Mar 20, 2025
Signed-off-by: Bálint Horváth <bal.horv.98@gmail.com>
HofiOne
added a commit
to HofiOne/syslog-ng
that referenced
this pull request
Mar 24, 2025
Signed-off-by: Hofi <hofione@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
max_object_sizeset to reasonably low values andupload_threadsset to anything other then 1. This bug could also have intermittently manifested withmax_object_sizeat higher values. This bug could not have been fixed with the current code structure, necessitating a refactor.SIGINTwhile a python destination is actively writing logs.New options:
object_key_suffix: This new option allows for a suffix after the multipart index. Useful for specifying file extension, thus its default value is.log❗ ❗ ❗ This pull request introduces two important changes: ❗ ❗ ❗
upload_threadsoption now governs the per-upload thread usage. This means the syslog-ng S3 destination driver now uses maximum(upload threads * max pending uploads) + 1threads, opposed toupload_threads + 1. Users with high python thread count should adjust their configuration accordingly.