stats: do not show orphan metrics for stats prometheus
#4921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the `stats prometheus` command is intended to be used to forward metrics to Prometheus or any other time-series database, displaying orphaned metrics should be avoided in order not to insert new data points when a given metric is no longer alive. Signed-off-by: László Várady <laszlo.varady@axoflow.com>
Signed-off-by: László Várady <laszlo.varady@axoflow.com>
furiel
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
stats prometheuscommand is intended to be used to forward metrics to Prometheus or any other time-series database, displaying orphaned metrics should be avoided in order not to insert new data points when a given metric is no longer alive.In case you are interested in the last known value of orphaned counters, use the
statsorquerysubcommands.