Skip to content

s3: make access_key and secret_key optional #4881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2024
Merged

s3: make access_key and secret_key optional #4881

merged 1 commit into from
Apr 5, 2024

Conversation

akunszt
Copy link
Contributor

@akunszt akunszt commented Apr 4, 2024

Making access_key and secret_key optional let the boto3 to execute the official credential chain process and use every supported authentication mechanism.

If the access_key and secret_key are set then those will be used as passing credentials in the parameter has the highest priority.

Please read this page about the credential order.

This solves issue #4858.

@akunszt
s3: make access_key and secret_key optional
1a20cb1 
Making access_key and secret_key optional let the boto3 to execute the
official credential chain process and use every supported authentication
mechanism.

If the access_key and secret_key are set then those will be used as
passing credentials in the parameter has the highest priority.

Please read [this](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html) page about the credential order.

This solves issue syslog-ng#4858.

Signed-off-by: Arpad Kunszt <akunszt@hiya.com>
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

1 similar comment
@kira-syslogng
Copy link
Contributor

This user does not have permission to start the build. Can one of the admins verify this patch and start the build?
(admin: you have the next options (make sure you checked the code):
"ok to test" to accept this pull request (and further changes) for testing
"test this please" for a one time test run
"add to whitelist" add author of a Pull Request to whitelist (globally, be careful, it means this user can trigger kira for any PR)
do nothing -> CI won't start)

@MrAnno
Copy link
Collaborator

MrAnno commented Apr 4, 2024

@kira-syslogng ok to test

alltilla
alltilla approved these changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@alltilla alltilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alltilla alltilla merged commit e50f2bc into syslog-ng:master Apr 5, 2024
alltilla added a commit to alltilla/syslog-ng that referenced this pull request Apr 5, 2024
@alltilla
news: add entry for syslog-ng#4881
61cd16a 
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
@akunszt akunszt deleted the issue-4858-aws-credential-chain branch April 5, 2024 08:05
MrAnno added a commit that referenced this pull request Apr 5, 2024
@MrAnno
Merge pull request #4883 from alltilla/news-4881
ffd06b9 
news: add entry for #4881
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@alltilla alltilla alltilla approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akunszt @kira-syslogng @MrAnno @alltilla