Skip to content

Conversation

alltilla
Copy link
Collaborator

@alltilla alltilla commented Oct 20, 2023

Follow up for #4666.

Fixing #4666 (comment) and #4666 (comment).

alltilla added a commit to alltilla/syslog-ng that referenced this pull request Oct 20, 2023
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
bazsi
bazsi previously approved these changes Oct 22, 2023
Copy link
Collaborator

@bazsi bazsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from a nitpick in a unit test this looks good to me.

Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
It better communicates the intention.

Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
Signed-off-by: Attila Szakacs <attila.szakacs@axoflow.com>
@alltilla alltilla force-pushed the driver-specific-templates-followup branch from 2d28c81 to 305ce52 Compare October 24, 2023 06:58
@alltilla alltilla merged commit 96367c3 into syslog-ng:master Oct 24, 2023
fekete-robert pushed a commit to axoflow/axosyslog-core-docs that referenced this pull request Nov 26, 2023
fekete-robert pushed a commit to axoflow/axosyslog-core-docs that referenced this pull request Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants