pdbtool: add validation for types of <value> tags #4621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In patterndb, you can add extra name-value pairs following a match with the <value> tags. But the actual value of these name-value pairs were never validated against their types, meaning that an incorrect value could be set using this construct. This patch adds this validation as an extra step in "pdbtool test" Signed-off-by: Balazs Scheidler <balazs.scheidler@axoflow.com>
|
This fixes #4599 |
OverOrion
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Thanks for the fix, checked it and works as expected!
Previously:
Setting value; name='more', value='foobar', type='int', msg='0x55ecd9502910', rcptid='0'
$ echo $?
0
Now:
Setting value; name='more', value='foobar', type='int', msg='0x561aaccae910', rcptid='0'
Value type validation failed, ${more} did not validate: int64(foobar)
$ echo $?
2
OverOrion
added a commit
to OverOrion/syslog-ng
that referenced
this pull request
Sep 19, 2023
Signed-off-by: Szilard Parrag <szilard.parrag@axoflow.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In patterndb, you can add extra name-value pairs following a match with the tags. But the actual value of these name-value pairs were never validated against their types, meaning that an incorrect value could be set using this construct. This patch adds this validation as an extra step in "pdbtool test"
This fixes #4599