Skip to content

Conversation

alexb271
Copy link
Contributor

@alexb271 alexb271 commented Jul 18, 2023

Resolves #3417

This PR enables using multiple systemd-journal() sources as long as they use different namespaces.

The persist names were already configured to use the systemd-journal namespace as part of the string, so no changes were needed with creating persist names.

alexb271 added a commit to alexb271/syslog-ng that referenced this pull request Jul 18, 2023
Signed-off-by: Alex Becker <beckeralex@protonmail.com>
@MrAnno MrAnno added this to the syslog-ng 4.4 milestone Jul 21, 2023
MrAnno
MrAnno previously requested changes Jul 24, 2023
alexb271 added a commit to alexb271/syslog-ng that referenced this pull request Jul 28, 2023
Signed-off-by: Alex Becker <beckeralex@protonmail.com>
alexb271 added a commit to alexb271/syslog-ng that referenced this pull request Aug 3, 2023
Signed-off-by: Alex Becker <beckeralex@protonmail.com>
@kira-syslogng
Copy link
Contributor

Build FAILURE

@alexb271
Copy link
Contributor Author

alexb271 commented Aug 3, 2023

@kira-syslogng retest this please

@kira-syslogng
Copy link
Contributor

Build FAILURE

@MrAnno MrAnno dismissed their stale review August 11, 2023 13:19

fixed

alexb271 added a commit to alexb271/syslog-ng that referenced this pull request Aug 28, 2023
Signed-off-by: Alex Becker <beckeralex@protonmail.com>
@kira-syslogng
Copy link
Contributor

Build FAILURE

alexb271 added a commit to alexb271/syslog-ng that referenced this pull request Aug 28, 2023
Signed-off-by: Alex Becker <beckeralex@protonmail.com>
@kira-syslogng
Copy link
Contributor

Build FAILURE

MrAnno
MrAnno previously approved these changes Aug 29, 2023
Copy link
Collaborator

@MrAnno MrAnno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍🏻

Please rebase your PR (to resolve a conflict).

…configured with different namespace() options

Signed-off-by: Alex Becker <beckeralex@protonmail.com>
Signed-off-by: Alex Becker <beckeralex@protonmail.com>
Signed-off-by: Alex Becker <beckeralex@protonmail.com>
@alexb271
Copy link
Contributor Author

LGTM. 👍🏻

Please rebase your PR (to resolve a conflict).

Thanks, I have rebased the PR.

@MrAnno
Copy link
Collaborator

MrAnno commented Aug 30, 2023

Thank you! :)

@MrAnno MrAnno merged commit bafbbaf into syslog-ng:master Aug 30, 2023
fekete-robert pushed a commit to axoflow/axosyslog-core-docs that referenced this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple systemd-journal() sources in the config
3 participants