Skip to content

Conversation

rasa
Copy link
Member

@rasa rasa commented Mar 22, 2025

This allows users to easily disable nightly builds in their forks, simply by disabling the
build-nightly action.

Testing

I tested it in my fork, and it works.

This allows users to easily disable nightly builds
in their forks, simply by disabling the
build-nightly action.
@calmh
Copy link
Member

calmh commented Mar 23, 2025

Congrats on #10000 :)

I was not aware you could reuse workflows like this, so thanks for showing me. However the docs say the called workflow needs an on: workflow_call: - does it really work? Or what works is that it doesn't run? :)

@rasa
Copy link
Member Author

rasa commented Mar 23, 2025

Congrats on #10000 :)

I was not aware you could reuse workflows like this, so thanks for showing me. However the docs say the called workflow needs an on: workflow_call: - does it really work? Or what works is that it doesn't run? :)

@calmh You're right, I had it in my fork but forgot to add it when I created the PR. It's there now. Thanks for catching.

Here are the runs showing it working on my fork.

@calmh calmh changed the title ci: Allow users to easily disable nightly builds ci: move nightly build schedule to separate workflow Mar 27, 2025
@calmh calmh changed the title ci: move nightly build schedule to separate workflow build: move nightly build schedule to separate workflow Mar 27, 2025
@calmh calmh enabled auto-merge (squash) March 27, 2025 09:15
@calmh calmh merged commit 7f3c8db into syncthing:main Mar 27, 2025
24 checks passed
@calmh calmh added this to the v1.29.4 milestone Mar 27, 2025
calmh added a commit to calmh/syncthing that referenced this pull request Mar 27, 2025
* main:
  build: move nightly build schedule to separate workflow (syncthing#10000)
  chore(syncthing): use file lock on certificate to prevent multiple instances (syncthing#10003)
  chore(ur): add RSS to reported stats (syncthing#10002)
  chore(gui, man, authors): update docs, translations, and contributors
calmh added a commit to p0l0us/syncthing that referenced this pull request Mar 28, 2025
* main: (175 commits)
  build: move nightly build schedule to separate workflow (syncthing#10000)
  chore(syncthing): use file lock on certificate to prevent multiple instances (syncthing#10003)
  chore(ur): add RSS to reported stats (syncthing#10002)
  chore(gui, man, authors): update docs, translations, and contributors
  chore(gui, man, authors): update docs, translations, and contributors
  fix(api): prevent tilde expansion in path suggestions (fixes syncthing#9990) (syncthing#9992)
  fix(syncthing): don't auto upgrade to higher major on startup (syncthing#9989)
  build(deps): update dependencies (syncthing#9988)
  chore(gui, man, authors): update docs, translations, and contributors
  refactor(api): extract method configMuxBuilder.postAdjustGui and add test coverage (syncthing#9979)
  refactor(api): make shutdown timeout configurable for tests (syncthing#9980)
  refactor(api): deduplicate HTTP test helpers and allow session cookie access (syncthing#9977)
  build: correct API call for Weblate statistics
  build(deps): update dependencies (syncthing#9978)
  chore(etc): remove /usr/bin prefix from Linux .desktop files (syncthing#9966)
  build: use Go 1.24, minimum is Go 1.23 (syncthing#9960)
  fix(policy): do not require multiple maintainers for build changes
  chore(gui, man, authors): update docs, translations, and contributors
  chore(fs): build kqueue instead of fsevents watcher on iOS (syncthing#9950)
  build(deps): update dependencies (syncthing#9951)
  ...
calmh added a commit to tomasz1986/syncthing that referenced this pull request Mar 28, 2025
…-is-disabled-for-Send-Only-folders

* main: (266 commits)
  build: move nightly build schedule to separate workflow (syncthing#10000)
  chore(syncthing): use file lock on certificate to prevent multiple instances (syncthing#10003)
  chore(ur): add RSS to reported stats (syncthing#10002)
  chore(gui, man, authors): update docs, translations, and contributors
  chore(gui, man, authors): update docs, translations, and contributors
  fix(api): prevent tilde expansion in path suggestions (fixes syncthing#9990) (syncthing#9992)
  fix(syncthing): don't auto upgrade to higher major on startup (syncthing#9989)
  build(deps): update dependencies (syncthing#9988)
  chore(gui, man, authors): update docs, translations, and contributors
  refactor(api): extract method configMuxBuilder.postAdjustGui and add test coverage (syncthing#9979)
  refactor(api): make shutdown timeout configurable for tests (syncthing#9980)
  refactor(api): deduplicate HTTP test helpers and allow session cookie access (syncthing#9977)
  build: correct API call for Weblate statistics
  build(deps): update dependencies (syncthing#9978)
  chore(etc): remove /usr/bin prefix from Linux .desktop files (syncthing#9966)
  build: use Go 1.24, minimum is Go 1.23 (syncthing#9960)
  fix(policy): do not require multiple maintainers for build changes
  chore(gui, man, authors): update docs, translations, and contributors
  chore(fs): build kqueue instead of fsevents watcher on iOS (syncthing#9950)
  build(deps): update dependencies (syncthing#9951)
  ...
@rasa rasa deleted the rs/sep-nightly branch April 9, 2025 14:32
@calmh calmh added the build Issues caused by or requiring changes to the build system (scripts or Docker image) label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues caused by or requiring changes to the build system (scripts or Docker image)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants