Skip to content

Conversation

polyfloyd
Copy link
Contributor

Exec accepts just the program name and will look for it in $PATH. This makes these files work on NixOS which does not create a /usr/bin directory.

Exec accepts just the program name and will look for it in $PATH. This
makes these files work on NixOS which does not create a /usr/bin
directory.
Copy link
Member

@calmh calmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me

@polyfloyd
Copy link
Contributor Author

Thanks!

Is anything else needed from me? The CI seems to be hanging

@calmh calmh changed the title chore(linux-desktop): Remove /usr/bin prefix from .desktop files chore(linux-desktop): remove /usr/bin prefix from .desktop files Feb 28, 2025
@calmh calmh changed the title chore(linux-desktop): remove /usr/bin prefix from .desktop files chore(etc): remove /usr/bin prefix from .desktop files Feb 28, 2025
@calmh calmh merged commit c3ce971 into syncthing:main Feb 28, 2025
24 checks passed
@polyfloyd polyfloyd deleted the desktop-no-prefix branch February 28, 2025 20:02
calmh added a commit to calmh/syncthing that referenced this pull request Mar 1, 2025
* main:
  build(deps): update dependencies (syncthing#9978)
  chore(etc): remove /usr/bin prefix from Linux .desktop files (syncthing#9966)
@calmh calmh added this to the v1.29.3 milestone Mar 9, 2025
calmh added a commit that referenced this pull request Mar 10, 2025
* main: (25 commits)
  refactor(api): make shutdown timeout configurable for tests (#9980)
  refactor(api): deduplicate HTTP test helpers and allow session cookie access (#9977)
  build: correct API call for Weblate statistics
  build(deps): update dependencies (#9978)
  chore(etc): remove /usr/bin prefix from Linux .desktop files (#9966)
  build: use Go 1.24, minimum is Go 1.23 (#9960)
  fix(policy): do not require multiple maintainers for build changes
  chore(gui, man, authors): update docs, translations, and contributors
  chore(fs): build kqueue instead of fsevents watcher on iOS (#9950)
  build(deps): update dependencies (#9951)
  refactor: using slices.Contains to simplify the code (#9918)
  build: switch to cloud code signing for Windows (#9948)
  chore(gui, man, authors): update docs, translations, and contributors
  chore(gui, man, authors): update docs, translations, and contributors
  fix(model): clarify errors on Windows user/group lookup (fixes #9929) (#9930)
  chore(gui, man, authors): update docs, translations, and contributors
  chore(scanner): don't warn about cancelled scan (#9920)
  chore(gui, man, authors): update docs, translations, and contributors
  chore(proto): change symlinktarget to be byte sequence (fixes #9913) (#9914)
  fix(api): don't crash requests after failing to unmarshal tokens (fixes #9909) (#9912)
  ...
calmh added a commit to p0l0us/syncthing that referenced this pull request Mar 28, 2025
* main: (175 commits)
  build: move nightly build schedule to separate workflow (syncthing#10000)
  chore(syncthing): use file lock on certificate to prevent multiple instances (syncthing#10003)
  chore(ur): add RSS to reported stats (syncthing#10002)
  chore(gui, man, authors): update docs, translations, and contributors
  chore(gui, man, authors): update docs, translations, and contributors
  fix(api): prevent tilde expansion in path suggestions (fixes syncthing#9990) (syncthing#9992)
  fix(syncthing): don't auto upgrade to higher major on startup (syncthing#9989)
  build(deps): update dependencies (syncthing#9988)
  chore(gui, man, authors): update docs, translations, and contributors
  refactor(api): extract method configMuxBuilder.postAdjustGui and add test coverage (syncthing#9979)
  refactor(api): make shutdown timeout configurable for tests (syncthing#9980)
  refactor(api): deduplicate HTTP test helpers and allow session cookie access (syncthing#9977)
  build: correct API call for Weblate statistics
  build(deps): update dependencies (syncthing#9978)
  chore(etc): remove /usr/bin prefix from Linux .desktop files (syncthing#9966)
  build: use Go 1.24, minimum is Go 1.23 (syncthing#9960)
  fix(policy): do not require multiple maintainers for build changes
  chore(gui, man, authors): update docs, translations, and contributors
  chore(fs): build kqueue instead of fsevents watcher on iOS (syncthing#9950)
  build(deps): update dependencies (syncthing#9951)
  ...
calmh added a commit to tomasz1986/syncthing that referenced this pull request Mar 28, 2025
…-is-disabled-for-Send-Only-folders

* main: (266 commits)
  build: move nightly build schedule to separate workflow (syncthing#10000)
  chore(syncthing): use file lock on certificate to prevent multiple instances (syncthing#10003)
  chore(ur): add RSS to reported stats (syncthing#10002)
  chore(gui, man, authors): update docs, translations, and contributors
  chore(gui, man, authors): update docs, translations, and contributors
  fix(api): prevent tilde expansion in path suggestions (fixes syncthing#9990) (syncthing#9992)
  fix(syncthing): don't auto upgrade to higher major on startup (syncthing#9989)
  build(deps): update dependencies (syncthing#9988)
  chore(gui, man, authors): update docs, translations, and contributors
  refactor(api): extract method configMuxBuilder.postAdjustGui and add test coverage (syncthing#9979)
  refactor(api): make shutdown timeout configurable for tests (syncthing#9980)
  refactor(api): deduplicate HTTP test helpers and allow session cookie access (syncthing#9977)
  build: correct API call for Weblate statistics
  build(deps): update dependencies (syncthing#9978)
  chore(etc): remove /usr/bin prefix from Linux .desktop files (syncthing#9966)
  build: use Go 1.24, minimum is Go 1.23 (syncthing#9960)
  fix(policy): do not require multiple maintainers for build changes
  chore(gui, man, authors): update docs, translations, and contributors
  chore(fs): build kqueue instead of fsevents watcher on iOS (syncthing#9950)
  build(deps): update dependencies (syncthing#9951)
  ...
@calmh calmh added the chore label May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants